[Bugfix] Fix the use of uninitialized variable in Par_EquilibriumIC #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The variable
parinPar_EquilibriumIC::Set_Velocity()is uninitialized ifkloops toparams.Cloud_MassProfNBin-1without eversum_mes>sum_radin the for loop.The resulting velocity of that particle will be polluted and become something unpredictable.
This may lead to extremely large particle velocity and extremely small time-steps.
Change
Assign a value to
parwhenk==params.Cloud_MassProfNBin-1in a similar way.Note
Related Issue:
Related PR: