Skip to content

Temporarily fix for MPI Barrier mismatch in InvokeSolver #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
koarakawaii wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Temporarily fix for MPI Barrier mismatch in InvokeSolver #489

koarakawaii wants to merge 1 commit into from

Conversation

@koarakawaii
Copy link
Contributor

@koarakawaii koarakawaii commented Nov 10, 2025 •
edited
Loading

  • This is only a temporary fix for issue MPI Barrier Synchronization Mismatch in InvokeSolver() #465 ; the PR is filed for recording purpose only
    • Need not only to match the TIMING_SYNC for Solver and Closing_Step, but also mimic the exactly same preprocessor (ifdef GRAVITY ..., etc) in function Preparation_Step for initiating TIMING_SYNC. This makes the code hard to maintain. So I think we should not really merge this.
  • If you agree, I'll close this PR @hyschive .

@hyschive hyschive marked this pull request as draft November 10, 2025 02:05
@hyschive
Copy link
Contributor

hyschive commented Nov 10, 2025

@koarakawaii I've converted it to a draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koarakawaii @hyschive