Fftw.cpp malloc size fix #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 5, 2025 18:22
…_local_size_3d_transposed() to estimate malloc size.
…amr->NPatchComma[0][1]/MPI_NRank
…). Add variable check to List_PID, List_k, TempBuf_SIdx, TempBuf_Var.
added 2 commits
June 6, 2025 11:20
…. And move fftw_mpi_local_size_3d_transposed() into these functions for mpi usage.
koarakawaii
reviewed
Jun 6, 2025
Contributor
koarakawaii
left a comment
koarakawaii
left a comment
There was a problem hiding this comment.
Hi, @xuanweishan: some minor comments are added. Please have a look 😺 ~
added 2 commits
June 6, 2025 15:27
Contributor
|
@hyschive : this PR looks fine to me now and @xuanweishan has tested it with |
koarakawaii
approved these changes
Jun 6, 2025
hyschive
approved these changes
Jun 6, 2025
Contributor
hyschive
left a comment
hyschive
left a comment
There was a problem hiding this comment.
@xuanweishan @koarakawaii Looks good. Thanks for the quick fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR reduce the virtual memory requirement of gamer with FFTW3.
Changes:
Init/Init_FFTW.cpp
fftw_mpi_local_size_3d_transposed()toComputePaddedTotalSize()andComputeTotalSize()for mpi supported situation to enhance the estimation of memory requirement.MemUnitestimation is not proper, it can't decrease the memory usage per rank with mpi. So we replace the valueMemUnitfromamr->NPatchComma[0][1]*PS1toamr->NPatchComma[0][1]/MPI_NRankMemUnitrelatedmallocandreallocto prevent error in after usage.Tests:
SERIALsupportOPT__FFTW_STARTUP = 1support