Reset END_T when using the dump table #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the initial time is always included in the dump table without duplications or disrupting order.
vivi235711
reviewed
Apr 17, 2025
Contributor
vivi235711
left a comment
vivi235711
left a comment
There was a problem hiding this comment.
I've tested this, and it works as expected. There's only one point that needs confirmation.
By the way, I’ve also created another PR hyschive#144 related to the dump table. Please take a look if you have time.
vivi235711
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
END_T < 0.0, reset the ending time as the time of the last dump. Otherwise, reset the ending time to the largest data dump time not greater than the inputEND_T.