Skip to content

Conversation

@daviwil
Copy link
Contributor

@daviwil daviwil commented May 31, 2020

This change adds a keyword parameter called headers to http-get so that an alist of request headers can be specified for the request. I've also converted the two existing optional parameters to keyword parameters to make it a little easier to call.

Since I'm not as familiar with the coding patterns of Gambit core libraries, could you help me figure out the right way to replace the macro-check-* calls that I removed from http-get? I'm not sure how that pattern changes when switching to keyword arguments.

/cc @FredericHamel

@lassik
Copy link
Contributor

lassik commented May 31, 2020

@feeley Just added a convenient define-procedure primitive but I don't think it supports keyword arguments yet.

@daviwil
Copy link
Contributor Author

daviwil commented May 31, 2020

Thanks! I might take a look to see if I can figure out how to add that if it's not there already.

@lassik
Copy link
Contributor

lassik commented May 31, 2020

050bdfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants