-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usegalaxy.org/ludwig_applications.yaml{.lock} #880
Open
paulocilasjr
wants to merge
4
commits into
galaxyproject:master
Choose a base branch
from
goeckslab:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natefoo
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well written tools, mostly looks good to me. A few thoughts, none of them critical:
- Explicitly overriding
$TMP*
like this is probably not a good idea, Galaxy defaults to tmp space in the job directory, and admins often override this as needed for particular destinations or tools. - I see Ludwig has this option to disable multithreading, which is exposed in the tool as an option for reproducibility purposes. But if Ludwig has an option for controlling the number of threads, I don't see it. What may happen is it gets scheduled on a node with 64 cores but is only allocated a fraction of those, assumes it can use them all, and blows up. If there is any way to pass in the number of cores, that would be great, otherwise we might have to get creative in scheduling.
- Minor, but
${dataset.element_identifier}
is typically the dataset name I believe? So this can result in some weirdness when creating those symlinks, but should be safe at least since they are quoted. - Also minor but lot of those
pwd
calls can probably just be replaced by.
, unless Ludwig changes the cwd internally. - This might fail under Pulsar, I am not sure if there is a "preferred" way of looking at tool stdout like this but the IUC channel probably has an answer.
- Should this be a
yaml.safe_dump()
? - Quoting construction in
ludwig_visualize.yml
is a bit creative but I think ok, but if an IUC person has a look at that as well that would be great.
@paulocilasjr thanks! A few comments from my side:
|
|
Thank you all for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ludwig-based Deep Learning Tools and Config File Generator
This PR introduces a suite of tools based on the Ludwig framework, allowing users to easily create and use deep-learning models without extensive code requirements.
Included Tools:
5 Ludwig-based tools:
Each tool serves a unique purpose within the deep learning model lifecycle, from data preprocessing to model evaluation.
Note: the tools are currently running through Docker.
1 Config File Generator:
This additional tool, though not Ludwig-based, assists users in creating the required config.yaml files. These configuration files are essential for several Ludwig tools, providing a streamlined setup process.
Installation sequence for
tool-installers
@galaxybot test this
@galaxybot deploy this
if test install was successful