Skip to content

Updating tools/mzmine from version 3.9.0 to 4.7.8 #7159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gxydevbot
Copy link
Collaborator

Hello! This is an automated update of the following tool: tools/mzmine. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.

I have updated tools/mzmine from version 3.9.0 to 4.7.8.

Project home page: http://mzmine.github.io

For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.

If you want to skip this change, close this PR without deleting the branch. It will be reopened if another change is detected.

Any commit from another author than 'planemo-autoupdate' will prevent more auto-updates.

To ignore manual changes and allow autoupdates, delete the branch.

@bernt-matthias
Copy link
Contributor

We should run the tests

<param name="input" location="https://raw.githubusercontent.com/mzmine/mzmine3/v@TOOL_VERSION@/src/test/resources/rawdatafiles/DOM_a.mzML,https://raw.githubusercontent.com/mzmine/mzmine3/v@TOOL_VERSION@/src/test/resources/rawdatafiles/DOM_b.mzXML"/>

@SaimMomin12
Copy link
Contributor

We should run the tests

<param name="input" location="https://raw.githubusercontent.com/mzmine/mzmine3/v@TOOL_VERSION@/src/test/resources/rawdatafiles/DOM_a.mzML,https://raw.githubusercontent.com/mzmine/mzmine3/v@TOOL_VERSION@/src/test/resources/rawdatafiles/DOM_b.mzXML"/>

Sorry, I overlooked the commented out tests, any idea why these were skipped earlier?

@bernt-matthias
Copy link
Contributor

Probably #5622 (comment) .. So I guess we can just reenable them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants