-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snippy: support --ctgs parameter #6591
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case?
tools/snippy/snippy.xml
Outdated
@@ -82,6 +87,10 @@ | |||
<when value="paired_iv"> | |||
<param name="fastq_input_interleaved" type="data" format="fastqsanger,fastqsanger.gz" label="Select fastq dataset" help="Specify dataset with interleaved reads"/> | |||
</when> | |||
<when value="contigs"> | |||
<param name="fasta_input" type="data" format="fasta,fa,fna" label="Select fasta dataset" help="Specify dataset with assembled contigs"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Galaxy we always call this fasta
:
<param name="fasta_input" type="data" format="fasta,fa,fna" label="Select fasta dataset" help="Specify dataset with assembled contigs"/> | |
<param name="fasta_input" type="data" format="fasta" label="Select fasta dataset" help="Specify dataset with assembled contigs"/> |
Do you know if (gzip) compressed input is supported? If so you could add fasta.gz
to the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help. I will add a test case, and check if fasta.gz is supported by snippy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bernt-matthias ,I added a test. By the way, Snippy does not support assembled contigs in fasta.gz format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more thing. I think the test failure is just temporary.
tools/snippy/snippy.xml
Outdated
<param name="fastq_input_selector" type="select" label="Single or Paired-end reads" help="Select between paired and single end data"> | ||
<option value="paired">Paired</option> | ||
<option value="single">Single</option> | ||
<option value="paired_collection">Paired Collection</option> | ||
<option value="single">Single</option> | ||
<option value="paired_iv">Paired Interleaved</option> | ||
<option value="contigs">Assembled Contigs</option> | ||
</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to modify the wording here, maybe like this:
<param name="fastq_input_selector" type="select" label="Single or Paired-end reads" help="Select between paired and single end data"> | |
<option value="paired">Paired</option> | |
<option value="single">Single</option> | |
<option value="paired_collection">Paired Collection</option> | |
<option value="single">Single</option> | |
<option value="paired_iv">Paired Interleaved</option> | |
<option value="contigs">Assembled Contigs</option> | |
</param> | |
<param name="fastq_input_selector" type="select" label="Input type" help="Select paired/single end raw read data or assembled contigs"> | |
<option value="paired">Paired end reads</option> | |
<option value="single">Single end reads</option> | |
<option value="paired_collection">Paired end reads in a collection</option> | |
<option value="paired_iv">Interleaved paired end reads</option> | |
<option value="contigs">Assembled Contigs</option> | |
</param> |
Hi @bernt-matthias. Thank you for your suggestions and review. I have made the corresponding modifications. |
FOR CONTRIBUTOR: