Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semibin2 to 2.1.0 #6503

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

astrovsky01
Copy link
Contributor

Update semibin2 to current version, adding compatibility strobealign aemb input files
FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@astrovsky01 astrovsky01 marked this pull request as draft October 31, 2024 14:57
<discover_datasets pattern="(?P&lt;designation&gt;.*)\/data_split.csv" format="csv" directory="output/samples/" recurse="true" match_relative_path="true"/>
</collection>
</xml>
<xml name="generate_sequence_features_extra_outputs">
<data name="single_cov" format="csv" from_work_dir="output/*_data_cov.csv" label="${tool.name} on ${on_string}: Coverage">
<filter>mode["select"]=="single" and extra_output and "coverage" in extra_output</filter>
<filter>input_type_select['mode']['select']=="single" and extra_output and "coverage" in extra_output</filter>
</data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This this just a copy of the data elements below? if so why not use macros for that?

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status here @astrovsky01

@astrovsky01
Copy link
Contributor Author

What is the status here @astrovsky01

Momentarily paused for a different priority

@astrovsky01 astrovsky01 marked this pull request as ready for review January 15, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants