Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spacexr #6212

Merged
merged 61 commits into from
Jan 15, 2025
Merged

add spacexr #6212

merged 61 commits into from
Jan 15, 2025

Conversation

nilchia
Copy link
Contributor

@nilchia nilchia commented Aug 6, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

This PR adds spacexr to Galaxy. This tool is used for cell-type deconvolution and cell type-specific differential expression in spatial transcriptomics.

tools/spacexr/macros.xml Outdated Show resolved Hide resolved
@nilchia
Copy link
Contributor Author

nilchia commented Oct 9, 2024

Is there another way other than "compare=sim_size" to check ".pdf" and ".rds" outputs?

#end for
#set $final_region = ', '.join($regions)
#set $final_region = "list(" + ", ".join(f"c({', '.join(map(repr, sublist))})" for sublist in $regions) + ")"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks wrong ... should final_region be a list() or a sting?

#set is executing a python expression and final_region is a python variable at this point.

Copy link
Contributor Author

@nilchia nilchia Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be a list.
I tried to do a trick and make an R list within a Python variable so I could use it in the script.

it should be a minimum:
final_region <- list(c("A","B",...),c("C","D",...),c("E","F",...),...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ... that is ... interesting :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but now I changed the input as a tabular file.
This makes more sense I guess :)

@nilchia nilchia marked this pull request as ready for review January 15, 2025 09:46
@bgruening bgruening merged commit ec96d43 into galaxyproject:main Jan 15, 2025
12 checks passed
@bgruening
Copy link
Member

Thanks @nilchia! Please consider writing a news item for this.

@mvdbeek
Copy link
Member

mvdbeek commented Jan 15, 2025

Attention: deployment failure!

https://github.com/galaxyproject/tools-iuc/actions/runs/12797958414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants