Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add report and fail level for lint #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

values are the defaults that will be introduced in galaxyproject/planemo-ci-action#23 but I think its a good idea to add them here anyway .. just in case anyone uses the repo as template.

fail level warn will be more strict that before, but I guess this is a good
idea

values are the defaults that will be introduced in galaxyproject/planemo-ci-action#23 but I think its a good idea to add them here anyway .. just in case anyone uses the repo as template.

fail level warn will be more strict that before, but I guess this is a good
idea
@mvdbeek
Copy link
Member

mvdbeek commented Sep 23, 2021

Before we can do this we need to fix the warnings, some of which need some thinking about (we warn on unlabelled workflow outputs for input parameters ... which kind of makes sense, but I don't know how to handle this)

@wm75
Copy link
Contributor

wm75 commented Sep 23, 2021

Would it make sense to just auto-label such outputs with the input param name?

@mvdbeek
Copy link
Member

mvdbeek commented Sep 23, 2021

I don't know. You mean the step label, right ? That wouldn't work for parameters that produce more than 1 output ... we don't have any of these, but you could imagine a range parameter, or an expression or regex that produces multiple values. Unless we'd always represent them as a single output ... which would make them less useful as input parameters, I guess.

We could auto-suggest something in the UI, I think that might be OK.
Maybe we just skip linting workflow outputs for input type parameters for now. @jmchilton do you have any thoughts on this ?

@mvdbeek
Copy link
Member

mvdbeek commented Sep 23, 2021

I think we need a new release of planemo-ci-action for this, right ?

@bernt-matthias
Copy link
Contributor Author

I think we need a new release of planemo-ci-action for this, right ?

Indeed. Maybe including galaxyproject/planemo-ci-action#20 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants