Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable longer reads by default for longer insert protocols #54

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable longer reads by default for longer insert protocols #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
177f5cb
Enabel longer reads by default for longer insert protocols
bwlang Aug 1, 2021
5b693e5
Actually 2000 is much better for this example data (1.4kb amplicons)
bwlang Aug 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ws/sars-cov-2-variant-calling/sars-cov-2-ont-artic-variant-calling/ont-artic-variation.ga
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"y": 710.5
},
"tool_id": null,
"tool_state": "{\"default\": 700, \"parameter_type\": \"integer\", \"optional\": true}",
"tool_state": "{\"default\": 2000, \"parameter_type\": \"integer\", \"optional\": true}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if there is some benefit in doing this we should probably make this a workflow parameter ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm fine with a workflow parameter, but I think it's good to also set the default based on this data (or other generate more data?)

"tool_version": null,
"type": "parameter_input",
"uuid": "be62c106-273a-4102-a9a1-1376525e4f4e",
Expand Down