Show tool with the latest version #9828
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show tool with the latest version as recommendations
lib/galaxy/tools/recommendations.py
Outdated
| all_tools = dict() | ||
| for t in a_tools: | ||
| t_versions = list() | ||
| for t_v in a_tools[t]: |
There was a problem hiding this comment.
Would be better to get the index without sorting.
Something along the lines of:
max_index, max_value = max(enumerate(values), key=operator.itemgetter(1))
There was a problem hiding this comment.
thanks, will test it and update
mvdbeek
requested changes
Jun 17, 2020
| @@ -100,13 +101,29 @@ def __set_model(self, trans, remote_model_url): | |||
| for k in tool_pos_sorted: | |||
| self.tool_weights_sorted[k] = tool_weights[str(k)] | |||
| # collect ids and names of all the installed tools | |||
| all_t = dict() | |||
| for tool_id, tool in trans.app.toolbox.tools(): | |||
| t_id_renamed = tool_id | |||
There was a problem hiding this comment.
You can use if tool.is_latest_version and then drop the other changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show tool with the latest version as recommendations. There are some tools with Ids such as Filter1, Cut1 with no-tool version information embedded in these. But there are tools such as Bowtie2, Trimmomatic which contain their versions embedded in their ids. While showing recommendations, it is useful to fetch the latest version of these tools (and users can change the versions if they like).