Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of public pages and workflows authored by deleted users #19394

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jan 10, 2025

Ref: #19343

to do:

  • list of public pages: do not display pages authored by deleted users
  • list of public workflows: do not display workflows authored by deleted users
  • public page view: replace purged user hash with "archived user"; remove link
  • public workflow view: same as above

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Create 2 new users
    2. Login as each user and create a page and a workflow; publish page and workflow, share workflow with your main user
    3. Delete one of the users
    4. Login as main user
    5. View public pages; verify that pages by the deleted user are not displayed
    6. View public workflows; verify that workflows by the deleted user are not displayed.
    7. View shared workflows, verify same as above.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs force-pushed the dev_deleted_users_items branch from 3d18f94 to 6611c17 Compare January 10, 2025 22:34
@jdavcs jdavcs force-pushed the dev_deleted_users_items branch from bc8da39 to 51a7137 Compare January 14, 2025 06:14
@jdavcs jdavcs marked this pull request as ready for review January 14, 2025 06:15
@jdavcs jdavcs force-pushed the dev_deleted_users_items branch from 51a7137 to dfba8ca Compare January 14, 2025 06:22
@jdavcs
Copy link
Member Author

jdavcs commented Jan 15, 2025

@mvdbeek yes, owner_deleted_or_purged doesn't look right. There are only 19 not deleted but purged records on main, which I'll fix manually. Here, we can switch to checking deleted status only: owner_deleted - would that be a better approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants