Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sniff den_fmt files where END header is on one line #17603

Open
wants to merge 1 commit into
base: release_23.2
Choose a base branch
from

Conversation

patrick-austin
Copy link
Contributor

sniff_prefix for the CASTEP den_fmt datatype checks for a particular phrase to appear in the file header. However, in files generated with more recent versions of CASTEP, this phrase appears on one single line whereas before it was split over two lines.

To correctly sniff all versions of the file, concat the two possible lines the phrase can be spread over and remove whitespace/newlines and compare using that.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
    • Added new test file with the "one line" END header: ...
  • This is a refactoring of components with existing test coverage.
    • Existing tests with Si.den_fmt and YbCuAs2.den_fmt should still pass
  • Instructions for manual testing are as follows:

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant