Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable some flake8-logging-format rules in ruff #16915

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Enable some flake8-logging-format rules in ruff #16915

merged 2 commits into from
Oct 25, 2023

Conversation

nsoranzo
Copy link
Member

and fix G003, G010 and G201 errors.
These rules should be uncontroversial hopefully.

xref. #16893 (comment)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Oct 25, 2023
@github-actions github-actions bot added this to the 23.2 milestone Oct 25, 2023
@nsoranzo nsoranzo force-pushed the ruff_logging_format branch from 7526f75 to 78e4577 Compare October 25, 2023 09:48
@nsoranzo nsoranzo mentioned this pull request Oct 25, 2023
Draft
4 tasks
@mvdbeek mvdbeek merged commit 7ee3412 into galaxyproject:dev Oct 25, 2023
@nsoranzo nsoranzo deleted the ruff_logging_format branch October 25, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/jobs area/tool-framework kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@nsoranzo @jmchilton @mvdbeek