Git rid of JQuery from ToolHelp.vue #14652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
requested changes
Sep 19, 2022
| export default { | ||
| props: { | ||
| content: { | ||
| type: String, | ||
| required: true, | ||
| }, | ||
| }, | ||
| computed: { | ||
| formattedContent() { | ||
| const $tmpl = $("<div/>").append(this.content); |
There was a problem hiding this comment.
It looks like this substantively changes the incoming content, to me, and that functionality would need to be updated instead of dropped?
i.e. -- it makes all of the anchors target a new window, and it rewrites static references in the tool help.
There was a problem hiding this comment.
And this PR turned green, and it should probably not :)
Please add some tests to make sure that the result is really the same before and after your modifications.
|
@MOHITRAJANI this needs a rebase and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the function formattedComponent which in turn used Jquery selector to directly using the content that comes from props which is already having the HTML that we need to render in String format. Related to task #11939
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License