Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a more appropriate error when there's no version table #13695

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Apr 8, 2022

Triggered only by the database task in the ansible galaxy role (which calls scripts/manage_db.py version directly, bypassing the manage_db.sh shell script)

This is for a better solution to galaxyproject/ansible-galaxy#151

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

Triggered by database task in ansible galaxy role
@jdavcs jdavcs added kind/bug area/database Galaxy's database or data access layer labels Apr 8, 2022
@jdavcs jdavcs added this to the 22.05 milestone Apr 8, 2022
@jdavcs jdavcs merged commit 68c4456 into galaxyproject:dev Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants