Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converters: add missing tests and add linting to converter tests #12202

Merged

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Jun 29, 2021

While working on #12073 I realized that tests of many converters use the wrong attribute format instead of ftype and that tests are missing for many converters.

The PR

  • adds planemo lint to the converter tests
  • adds tests to almost all converters (a few are excluded via a new skiplist)

This replaces #12104 (in parts).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@github-actions github-actions bot added this to the 21.09 milestone Jun 29, 2021
@bernt-matthias bernt-matthias changed the title Topic/converters/test lint ftype Converters: add missing tests and add linting to converter tests Jun 29, 2021
@bernt-matthias bernt-matthias force-pushed the topic/converters/test-lint-ftype branch from 3345eaa to bc0f69f Compare June 29, 2021 09:03
@bernt-matthias bernt-matthias force-pushed the topic/converters/test-lint-ftype branch from d0c2414 to 109ba3b Compare June 29, 2021 12:14
@bernt-matthias bernt-matthias force-pushed the topic/converters/test-lint-ftype branch 3 times, most recently from a8550b8 to 3ba0b3e Compare June 30, 2021 11:57
@bernt-matthias
Copy link
Contributor Author

Heureka. Tests are passing. Good to go from my side.

@jmchilton jmchilton merged commit 91109c9 into galaxyproject:dev Jun 30, 2021
@jmchilton
Copy link
Member

Amazing - thank you so much!

@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@bernt-matthias bernt-matthias deleted the topic/converters/test-lint-ftype branch June 30, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants