-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converters: add missing tests and add linting to converter tests #12202
Merged
jmchilton
merged 17 commits into
galaxyproject:dev
from
bernt-matthias:topic/converters/test-lint-ftype
Jun 30, 2021
Merged
Converters: add missing tests and add linting to converter tests #12202
jmchilton
merged 17 commits into
galaxyproject:dev
from
bernt-matthias:topic/converters/test-lint-ftype
Jun 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since format is wrong
- add skiplist to converter tests and lints Co-authored-by: Nicola Soranzo <[email protected]>
- bz2_to_uncompressed - cram_to_bam
3345eaa
to
bc0f69f
Compare
d0c2414
to
109ba3b
Compare
13 tasks
nsoranzo
reviewed
Jun 29, 2021
lib/galaxy/datatypes/converters/encodepeak_to_bgzip_converter.xml
Outdated
Show resolved
Hide resolved
a8550b8
to
3ba0b3e
Compare
Co-authored-by: Nicola Soranzo <[email protected]>
Heureka. Tests are passing. Good to go from my side. |
Amazing - thank you so much! |
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #12073 I realized that tests of many converters use the wrong attribute
format
instead offtype
and that tests are missing for many converters.The PR
planemo lint
to the converter testsThis replaces #12104 (in parts).
How to test the changes?
(Select all options that apply)
License