Themes #194
Themes #194
Conversation
|
I think the failing tests might be caused by broken dependencies in dev |
|
@natefoo can you give this a look? |
mira-miracoli
force-pushed
the
themes
branch
from
beef4f3 to
d9e9b71
Compare
|
The archive/unarchive is going to result in a lot of always-run tasks, I think? But I also recall you mentioned some reason that using the |
I don't know anymore why it did not work in the past. Now it works :D |
|
Are you ok with the latest changes? |
tasks/main.yml
Outdated
|
|
||
| - name: Create welcome.html directory for basedomain | ||
| ansible.builtin.file: | ||
| state: directory | ||
| mode: '0755' | ||
| owner: "{{ __galaxy_privsep_user_name }}" | ||
| group: "{{ __galaxy_privsep_user_group }}" | ||
| path: "{{ galaxy_themes_static_path }}/static/welcome.html" | ||
| when: galaxy_manage_subdomain_static | ||
|
|
||
| - name: Template welcome.html for basedomain | ||
| ansible.builtin.template: | ||
| src: welcome.html.j2 |
There was a problem hiding this comment.
I think all of the when: galaxy_manage_subdomain_static could be moved into a separate file to match the rest of main.yml that does conditional includes.
Co-authored-by: Helena <[email protected]>
Co-authored-by: Helena <[email protected]>
Co-authored-by: Helena <[email protected]>
Co-authored-by: Helena <[email protected]>
|
🎉 |
This was a long one, congrats to you all 🚀! |
I included the ansible-galaxy-subdomains role in this one and updated it to the new galaxy-integrated per_host functionality. See
For details