-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react): introduce changeset tool for change tracking #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/react/package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there are reason why these new Deps are added to the react package and not to the root? I was expecting to do pnpm changeset
at the root, but am unable to since all of the changeset stuff is in the react package.
The CLI UI then asks about all of the packages in the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason that the version number isn't in the changeset is because you could have several changesets in the same version. With this tool as I understand it, it will effectively bundle all the individual change files into one changelog, and it will suggest the new version number based on the minor/major changes involved
I don't think we want to track the changelog for all the packages in the repo, just for @gadgetinc/react for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I've had a good experience using changesets in ggt
"commit": false, | ||
"fixed": [], | ||
"linked": [], | ||
"access": "restricted", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: If you plan to have changesets release to npm then this will need to be public
.
5d7c6bb
to
744e54b
Compare
A tool for managing a change log to the library
PR Checklist