Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updated spec params and add a comment for new useNavigate prop #296

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix updated spec params and add a comment for new useNavigate prop #296

merged 1 commit into from
Oct 27, 2023

Conversation

jasong689
Copy link
Contributor

I merged 2 PRs however one updated the signature of one of the test utils. This fixes that and adds a comment to the useNavigate prop. Also bump the version to 0.14.14

PR Checklist

  • Important or complicated code is tested
  • Any user facing changes are documented in the Gadget-side changelog
  • Any immediate changes are slated for release in Gadget via a generated package dependency bump
  • Versions within this monorepo are matching and there's a valid upgrade path

@jasong689 jasong689 requested a review from infiton October 27, 2023 14:30
infiton
infiton approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@infiton infiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment suggestion then 🚀

@jasong689 jasong689 merged commit 5bac517 into main Oct 27, 2023
8 checks passed
@jasong689 jasong689 deleted the bump-react-version branch October 27, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiton infiton infiton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasong689 @infiton