Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth config to the object returned from useAuth #292

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Add auth config to the object returned from useAuth #292

merged 1 commit into from
Oct 27, 2023

Conversation

jasong689
Copy link
Contributor

@jasong689 jasong689 commented Oct 23, 2023 •
edited
Loading

Users may need to access things like signInPath, redirectOnSuccessfulSignInPath, etc... in components. An example would be

<Link to={authConfig.signInPath} />

instead of needing to do

<Link to={window.gadgetConfig.authentication.signInPath />

closes GGT-5051

PR Checklist

  • Important or complicated code is tested
  • Any user facing changes are documented in the Gadget-side changelog
  • Any immediate changes are slated for release in Gadget via a generated package dependency bump
  • Versions within this monorepo are matching and there's a valid upgrade path

@jasong689 jasong689 requested review from infiton and jcao49 October 24, 2023 15:32
@jasong689 jasong689 marked this pull request as ready for review October 24, 2023 15:34
@jasong689 jasong689 merged commit 3e75421 into main Oct 27, 2023
@jasong689 jasong689 deleted the auth-config branch October 27, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcao49 jcao49 jcao49 approved these changes

@infiton infiton infiton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasong689 @infiton @jcao49