Backup one file at a time #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 56239d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
scott-rc
force-pushed
the
sc/backup-one-file-at-a-time
branch
from
38fb4e9 to
e7d0ae3
Compare
scott-rc
force-pushed
the
sc/backup-one-file-at-a-time
branch
from
e7d0ae3 to
56239d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the
Error: dest already exists.issues that keep popping up.While trying to reproduce this issue, I noticed the
Error: dest already exists.error being logged when I deleted a model in Gadget's editor and then ranggt pull. The error was happening while attempting to move deleted files into.gadget/backup/. The deleted files that failed to move into.gadget/backup/eventually succeeded because we wrap the move within apRetry, so I didn't experience the final failure that causes ggt to crash.I'm not sure how the file moves eventually succeeded because I didn't see the
"removing file in the way of backup path"log line, which is how we typically recover from failing to move a file into.gadget/backup/... my current theory is that all of these issues are stemming from moving all the files in parallel, so this PR changes our file move logic to move all the files one at a time. After making this change, I didn't see any moreError: dest already exists.errors after deleting a model in Gadget's editor and runningggt pull.