Skip to content

Commit

Permalink
Fix lint config after switching to a yarn workspace broke it
Browse files Browse the repository at this point in the history
  • Loading branch information
airhorns committed Jul 6, 2021
1 parent 4fabfe0 commit a353a77
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 15 deletions.
7 changes: 4 additions & 3 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/client
/node
/esm
packages/fastify-renderer/client
packages/fastify-renderer/node
packages/fastify-renderer/*.config.js
packages/test-apps/simple-react/dist
7 changes: 3 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
module.exports = {
parser: '@typescript-eslint/parser', // Specifies the ESLint parser
parser: '@typescript-eslint/parser',
parserOptions: {
ecmaVersion: 2020, // Allows for the parsing of modern ECMAScript features
sourceType: 'module', // Allows for the use of imports
project: ['./packages/**/*/tsconfig.json'],
tsconfigRootDir: __dirname,
project: ['./packages/fastify-renderer/tsconfig.eslint.json', './packages/test-apps/simple-react/tsconfig.json'],
},
settings: {
react: {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
node-version: [14.x, 16.x]
os: [ubuntu-latest, windows-latest]
os: [ubuntu-latest]

steps:
- uses: actions/checkout@v1
Expand Down
4 changes: 4 additions & 0 deletions packages/fastify-renderer/tsconfig.eslint.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"extends": "../../tsconfig.json",
"include": ["src", "test"]
}
4 changes: 2 additions & 2 deletions packages/test-apps/simple-react/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ export const server = async () => {
await server.register(async (instance) => {
instance.setRenderConfig({ base: '/subpath' })

instance.get('/subpath/this', { render: require.resolve('./subapp/This') }, async (request) => {
instance.get('/subpath/this', { render: require.resolve('./subapp/This') }, async (_request) => {
return {}
})
instance.get('/subpath/that', { render: require.resolve('./subapp/That') }, async (request) => {
instance.get('/subpath/that', { render: require.resolve('./subapp/That') }, async (_request) => {
return {}
})
})
Expand Down
2 changes: 1 addition & 1 deletion packages/test-apps/simple-react/subapp/This.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import { Link } from 'wouter'

const This = (props: { time: number }) => {
const This = (_props: { time: number }) => {
return (
<>
<h1>This</h1>
Expand Down
4 changes: 0 additions & 4 deletions tsconfig.eslint.json

This file was deleted.

0 comments on commit a353a77

Please sign in to comment.