Update grpc/grpc-js for deadline exceeded logging improvements #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing for the same reason they are failing on main I believe |
airhorns
force-pushed
the
updated-js-deps
branch
from
70c7138 to
e00b07e
Compare
|
This is in better shape now! |
angelini
reviewed
Apr 26, 2024
| * @param project The id of the project. | ||
| * @param obj The object to update. | ||
| * @returns The latest project version or `null` if something went wrong. | ||
| * @returns The latest project version or `null` if something went wrong. |
There was a problem hiding this comment.
I have no idea why but my and Scott's auto formatter was setting it up this way.
angelini
reviewed
Apr 26, 2024
| @@ -1 +1,4 @@ | |||
| /** | |||
| * | |||
| */ | |||
angelini
approved these changes
Apr 26, 2024
airhorns
force-pushed
the
updated-js-deps
branch
from
43c8bdf to
32e5ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/grpc/grpc-node/releases includes a number of bugfixes as well as some enhancements to the
RpcError: Deadline Exceedederror message specifically. Lets use the new one!