Skip to content

Commit

Permalink
feat!: update models to vrs 2.0.0 community review ballot (#471)
Browse files Browse the repository at this point in the history
close #469 

* Update modules to vrs
[2.0.0-ballot.2024-11.3](https://github.com/ga4gh/vrs/tree/2.0.0-ballot.2024-11.3)
tag
* Rename class `_Ga4ghIdentifiableObject` to `Ga4ghIdentifiableObject`
* Removes `entity_models` and `domain_models` from `ga4gh.core`. Now,
all gks-core models are in `ga4gh.core.models`.
* gks-core includes `date` and `datetime` as primitives, however the
builtin `datetime` module already provides these. Initially, I kept them
as Pydantic Root Models but I think we should just leverage the
`datetime` module instead.
  • Loading branch information
korikuzma authored Dec 20, 2024
1 parent 11c4f97 commit 01e3038
Show file tree
Hide file tree
Showing 15 changed files with 409 additions and 646 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[submodule "submodules/vrs"]
path = submodules/vrs
url = https://github.com/ga4gh/vrs.git
branch = 2.x
branch = 2.0.0-ballot.2024-11
7 changes: 2 additions & 5 deletions src/ga4gh/core/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
from .pydantic import (
is_pydantic_instance, is_curie_type, pydantic_copy
)
from .domain_models import CommonDomainType
from . import entity_models, domain_models
from . import models as core_models

__all__ = [
"sha512t24u",
Expand All @@ -37,9 +36,7 @@
"is_pydantic_instance",
"is_curie_type",
"pydantic_copy",
"CommonDomainType",
"entity_models",
"domain_models"
"core_models",
]

try:
Expand Down
131 changes: 0 additions & 131 deletions src/ga4gh/core/domain_models.py

This file was deleted.

Loading

0 comments on commit 01e3038

Please sign in to comment.