Documentation updates to support late shift to using Propositions in Statements #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating text on the Statement page to reflect last minute shift to using Propositions in Statements
Updating example link to use the test fixtures scv example.
updating text in Base Profiles landing page to better describe the current state or affairs.
Updating text of Proposition Profiles page to reflect current state of affairs
minor edits/updates
removing out of date Statement data structure diagram.
adding updated statement data structure (detailed) diagram, w propositions
adding updated detailed Statement data structure diagram
removing outdated statement semantics diagram, to be replaced
updated version of statement semantics diagram that includes propositions
updating text to accommodate shift to use propositions in Statements
ahwagner
requested changes
Dec 3, 2024
There was a problem hiding this comment.
I think we should clarify what we mean by profile in our documentation. Here we use it to describe domain-specific base models such as the proposition types that follow the general SEPIO information model, but also to describe community-specific constraints on these models (which is what I typically think of as profiles). These are different things and I think we shouldn’t conflate them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating text on the Statement page to reflect last minute shift to using Propositions in Statements.
READY FOR MERGING