Update core-im-source.yaml #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding additional attributes and classes to the core-im-source file from the full/informtive model.
|
Initial PR adding new v1-qualified content to the core-im-source file is complete and ready for review/merging. A subsequent series of PRs will be submitted that make edits/refinements to existing class/attribute descriptions. |
Continued adding new classes and properties to the core-im.
More additions to flesh out the v1 core-im.
- Fixed range/data type for `StudyResult.dataItems` property - added an 'extends' element to `VariantClassification.classification` property
Added an 'extends:derivedFrom' line to the StudyResult.sourceDataSet proeprty.
|
I'm bypassing the requirement for a review since both Alex and I have edited the primary changes offerred by Matt B. At this point we would have to wait on yet another individual to review, which I don't think is prudent or necessary at this point in the process of getting the schemas and docs in MVP working order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional attributes and classes to the core-im-source file from the full/informative model.