Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fractional resource requirements for CWL 1.1 and 1.2 spec #230

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

vsmalladi
Copy link
Contributor

Closes #139

Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would perhaps wait with merging until #219 is merged and develop is merged into develop-v1.2

Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsmalladi: Should develop-v1.2 perhaps be rebased to current develop, given that this PR now has 133 commits with changes that are completely unrelated to the issue the PR attempts to address?

@vsmalladi
Copy link
Contributor Author

Yes merged develop back onto develop-v1.2 should solve this issue now

Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsmalladi vsmalladi merged commit 56a54fa into develop-v1.2 Mar 5, 2025
6 checks passed
@vsmalladi vsmalladi deleted the 132-fractional branch March 5, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants