Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR comment for OpenAPI Diff output #227

Merged
merged 47 commits into from
Feb 10, 2025
Merged

PR comment for OpenAPI Diff output #227

merged 47 commits into from
Feb 10, 2025

Conversation

uniqueg
Copy link
Contributor

@uniqueg uniqueg commented Oct 29, 2024

  • Do not fail when OpenAPI Diff action errors
  • Instead, create PR comment with error log
  • Currently does not work because of permission issues (403 on trying to create comment); may need to set PAT in github-script action, but don't have permissions to do that for this repo
  • Otherwise works fine

Produces output like this:

diff.md

@uniqueg uniqueg marked this pull request as draft October 30, 2024 00:24
@uniqueg uniqueg requested a review from vsmalladi October 30, 2024 00:29
@vsmalladi vsmalladi self-requested a review October 31, 2024 15:31
@vsmalladi vsmalladi changed the base branch from main to develop January 24, 2025 13:58
@vsmalladi vsmalladi requested a review from Copilot January 24, 2025 16:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@vsmalladi
Copy link
Contributor

@uniqueg still issue with permissions. But got a workaround to upload the artifact with error log.
diff-artifacts (2).zip

@vsmalladi
Copy link
Contributor

@uniqueg I think i fixed this.

@vsmalladi vsmalladi marked this pull request as ready for review February 7, 2025 15:51
@vsmalladi vsmalladi requested a review from Copilot February 7, 2025 15:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.

@vsmalladi vsmalladi requested a review from Copilot February 10, 2025 19:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@vsmalladi vsmalladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Merging in now.

@vsmalladi vsmalladi merged commit 91c5064 into ga4gh:develop Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants