Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notebook for submitting civic assertions via prod api #13

Open
wants to merge 5 commits into
base: issue-10
Choose a base branch
from

Conversation

korikuzma
Copy link
Collaborator

close #12

Probably didn't need a PR, but thought I'd save work.

@korikuzma korikuzma added the priority:low Low priority label May 28, 2024
@korikuzma korikuzma requested review from ahwagner and larrybabb May 28, 2024 23:06
@korikuzma korikuzma self-assigned this May 28, 2024
@korikuzma korikuzma marked this pull request as draft May 28, 2024 23:16
@korikuzma korikuzma marked this pull request as ready for review May 29, 2024 13:17
Copy link
Collaborator

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what all this is. But I approve. 😁

@korikuzma
Copy link
Collaborator Author

@larrybabb @ahwagner SCV005045671 and SCV005045669 are now viewable on the ClinVar UI

@ahwagner
Copy link
Member

Looking at this, it appears that there are some slight differences between the automated and manual submissions:
image

image

Primarily 1) links to the associated CIViC AID and EID records and 2) link to the appropriate method for each assertion type.

Copy link
Member

@ahwagner ahwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korikuzma
Copy link
Collaborator Author

Primarily 1) links to the associated CIViC AID and EID records

@ahwagner see this comment and the following comment. I had trouble submitting CIViC URLs

@korikuzma
Copy link
Collaborator Author

  1. link to the appropriate method for each assertion type.

@ahwagner Hm. I will look into this later.

@korikuzma
Copy link
Collaborator Author

@ahwagner I am going to email the ClinVar team to see if there is a way to include this information using the API or if it's not supported yet.

* this should link to the guideline
@korikuzma
Copy link
Collaborator Author

@ahwagner I am going to email the ClinVar team to see if there is a way to include this information using the API or if it's not supported yet.

@ahwagner I emailed giving them examples of citations with URLs (including the germline test submission) with failures. They confirmed URLs are not working with the API but that the development team is discussing and will get back to us.

I’ve submitted an update to include guideline PMID and hoping it shows in the UI soon.

@korikuzma
Copy link
Collaborator Author

SCV005045669 link to guidelines has been updated (added assertionCriteria). Still waiting on onco to be updated.
Screenshot 2024-07-01 at 07 31 28

@korikuzma
Copy link
Collaborator Author

@ahwagner I emailed giving them examples of citations with URLs (including the germline test submission) with failures. They confirmed URLs are not working with the API but that the development team is discussing and will get back to us.

They confirmed it is a bug and will let us know when it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants