Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always emit plugin.js into plugin repository #725

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Always emit plugin.js into plugin repository #725

merged 3 commits into from
Feb 11, 2025

Conversation

volterra79
Copy link
Member

@volterra79 volterra79 commented Feb 11, 2025

Copy plugin.js compiled file into plugin code folder to allow npm run build and choose plugin to copy to admin folder

@volterra79 volterra79 added bug Something isn't working backport to v3.11.x labels Feb 11, 2025
@volterra79 volterra79 added this to the v4.0 milestone Feb 11, 2025
@volterra79 volterra79 requested a review from Raruto February 11, 2025 08:36
@volterra79 volterra79 self-assigned this Feb 11, 2025
@Raruto Raruto added config Anything related to configuration files and removed bug Something isn't working labels Feb 11, 2025
@Raruto Raruto changed the title 🐛 Copy plugin.js to plugin code folder after build completion Always emit plugin.js into plugin repository Feb 11, 2025
@Raruto Raruto enabled auto-merge (squash) February 11, 2025 09:33
@Raruto Raruto merged commit 7b361cd into dev Feb 11, 2025
1 check passed
@Raruto Raruto deleted the cp_plugin.js branch February 11, 2025 09:34
Copy link

The backport to v3.11.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v3.11.x v3.11.x
# Navigate to the new working tree
cd .worktrees/backport-v3.11.x
# Create a new branch
git switch --create backport-725-to-v3.11.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7b361cd57a64a12c0efa86852553d16b1821ad42
# Push it to GitHub
git push --set-upstream origin backport-725-to-v3.11.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v3.11.x

Then, create a pull request where the base branch is v3.11.x and the compare/head branch is backport-725-to-v3.11.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to v3.11.x config Anything related to configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants