Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔙 from #579 - Click to go back button to show MacroGroup list from Group page within ChangeMapMenu.vue #585

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

github-actions[bot]
Copy link

Backport ebb57cd from #579 to v3.9.x.

Depends on: g3w-suite/g3w-admin#761

Changes: "click to go back behavior"

Screenshot from 2024-02-19 15-17-35

Before: "goes straight back to the root"

Screenshot from 2024-02-19 15-20-23

After: "show macro group content" and then "go back to root""

Screenshot from 2024-02-19 15-17-51

Screenshot from 2024-02-19 15-20-23

…n `ChangeMapMenu.vue` (#579)

* add cache

* Temp dev

* Check if current project (initiial) belong to a macrogroup/s checking initCongif.group.macrogroup_id attribute

* avoid nested conditions

* replace `this._cache` with internal functions `get_macro(id)` + `get_group(id)`

* missing `cb`

* Show macrogroups list if a project initial group belong to more than one macro groups

* Show macrogroups list if a project initial group belong to more than one macro groups: Improving

* Show macrogroups if init project belong to a group inside more than one macrogroups

* remove padding

* Revert "remove padding"

This reverts commit 540c938.

* code clean up

* Fix case of group.id == macrogroup.id

* remove `setFallBackImage` and `macrogroupsandgroups `

* remove `isChildNode` and `_onChangeRoot`

* jsdoc

* Fix .on register event. Need to be a function

---------

Co-authored-by: Raruto <[email protected]>
(cherry picked from commit ebb57cd)
@github-actions github-actions bot added the ux Changes to a current behavior to improve user experience label Feb 26, 2024
@volterra79 volterra79 self-assigned this Feb 26, 2024
@volterra79 volterra79 requested a review from Raruto February 26, 2024 15:04
@volterra79 volterra79 added this to the v3.9 milestone Feb 26, 2024
@volterra79 volterra79 merged commit 51f0a87 into v3.9.x Feb 26, 2024
@volterra79 volterra79 deleted the backport-579-to-v3.9.x branch February 26, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux Changes to a current behavior to improve user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant