Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure switching layer legend styles change after changing map theme #552

Merged
merged 11 commits into from
Jan 31, 2024

Conversation

volterra79
Copy link
Member

@volterra79 volterra79 commented Jan 30, 2024

Closes: #551

Before

Screenshot from 2024-01-30 15-14-43

After

Screenshot from 2024-01-30 15-20-29

@volterra79 volterra79 added the bug Something isn't working label Jan 30, 2024
@volterra79 volterra79 added this to the v3.9 milestone Jan 30, 2024
@volterra79 volterra79 self-assigned this Jan 30, 2024
volterra79 added a commit to g3w-suite/g3w-admin that referenced this pull request Jan 30, 2024
@volterra79 volterra79 requested a review from Raruto January 30, 2024 16:25
@Raruto Raruto changed the title TOC layer legend doesn't change when change map theme Ensure switching layer legend styles change after changing map theme Jan 31, 2024
@volterra79 volterra79 modified the milestones: v3.9, v3.10 Jan 31, 2024
@volterra79 volterra79 merged commit c84e2be into dev Jan 31, 2024
1 check passed
@volterra79 volterra79 deleted the issue_551 branch January 31, 2024 13:39
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
…552)

* Pass syle options attribute

* Pass right style layer of current map theme

* Comment

* refactor function `changeMapTheme`

* debug `stylesfeaturecount` is undefined

* 🐛 skip if a layer hasn't feature count option set on QGIS project

* jsdoc

* Style categories is not related to legend position but on map_theme

---------

Co-authored-by: Raruto <[email protected]>
(cherry picked from commit c84e2be)
volterra79 added a commit that referenced this pull request Jan 31, 2024
…552) (#559)

* Pass syle options attribute

* Pass right style layer of current map theme

* Comment

* refactor function `changeMapTheme`

* debug `stylesfeaturecount` is undefined

* 🐛 skip if a layer hasn't feature count option set on QGIS project

* jsdoc

* Style categories is not related to legend position but on map_theme

---------

Co-authored-by: Raruto <[email protected]>
(cherry picked from commit c84e2be)

Co-authored-by: Francesco Boccacci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to v3.9.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer legend doesn't change when change map theme
2 participants