Skip to content

Null Safety, Better Camera Permissions, Updated Flutter Embedding #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jeffmikels wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Null Safety, Better Camera Permissions, Updated Flutter Embedding #20

jeffmikels wants to merge 5 commits into from

Conversation

@jeffmikels
Copy link

@jeffmikels jeffmikels commented Nov 12, 2021

This is a major update to the plugin.

  • the dart is now null safe
  • it now makes use of the current Flutter Embedding techniques
  • Android permissions have been reduced.

vanlooverenkoen
vanlooverenkoen reviewed Nov 18, 2021
View reviewed changes
android/src/main/kotlin/fr/g123k/torch_compat/TorchCompatPlugin.kt
}

override fun onMethodCall(@NonNull call: MethodCall, @NonNull result: Result) {
if (call.method == "getPlatformVersion") {
Copy link

@vanlooverenkoen vanlooverenkoen Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vanlooverenkoen vanlooverenkoen vanlooverenkoen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffmikels @vanlooverenkoen