Repository navigation
test(e2e): wait for the settled autocomplete status row - #179
Merged
Merged
Conversation
searchbox.tsx renders "搜尋中…" and "沒有符合結果" as two different <li> elements. The dark-mode contrast test measured the first .is-status row, so on a slow runner it read the searching row after React had swapped it out: getComputedStyle on the detached node returned "" (CI run 38908437195). Target the settled "沒有符合結果" row directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the E2E failure in CI run 38908437195 (dark-mode.spec.ts:786). searchbox.tsx swaps the 搜尋中…