Repository navigation
fix: 重複字各自獨立鏤空描寫(#175) - #176
Merged
Merged
Conversation
Contributor
Author
|
@audreyt 這筆修復,還請得便檢閱。若確認無誤,由您那邊merge + deploy好嗎? 謝謝! |
audreyt
approved these changes
Oct 14, 2026
audreyt
left a comment
Member
There was a problem hiding this comment.
確認無誤。segment.part 同時當 React row key 和 canvas/描寫狀態 id,重複字會覆寫到最後一個 canvas。改成出現位置加字面後,ref、draw state、pointer/touch/mouse handler 都走同一個 id;清除描寫仍掃全部 canvas。CI 全綠,含新的滑鼠與觸控 e2e。核准並合併,接著上 staging,驗證後再上正式站。
Member
|
已合併並上線。重複字的鏤空描寫各自獨立;staging 與正式站都用「飛飛龍飛」逐一描寫確認過,筆跡只留在當下那個字,「清除描寫」會清空全部。正式站 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正
Closes #175
範圍與風險
驗證
vp run build:通過。E2E_SKIP_BUILD=1 vp exec playwright test --project=chromium tests/e2e/charimg-drawing.spec.ts tests/e2e/charimg-caption-dark-contrast.spec.ts tests/e2e/dictionary.spec.ts tests/e2e/interactions.spec.ts tests/e2e/stroke-animation.spec.ts:108 passed。vp test run --project unit tests/unit/character-image-view.test.tsx:1 passed。vp run check:css-ids:通過,0 unallowed collisions。vp check && vp run typecheck:格式與 typecheck 通過,0 errors;未修改的scripts/lib/r2-upload.mjs:300有 1 項 no-control-regex warning。vp check --fix:通過。