-
-
Notifications
You must be signed in to change notification settings - Fork 130
Added options to customize logo, addon name and discord #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -443,6 +443,9 @@ def get_urls_with_passwords(urls, passwords): | |||||||||||||
| "COMET", | ||||||||||||||
| f"TMDB Read Access Token: {settings.TMDB_READ_ACCESS_TOKEN if settings.TMDB_READ_ACCESS_TOKEN else 'Shared'}", | ||||||||||||||
| ) | ||||||||||||||
| logger.log("COMET", f"Custom Logo URL: {bool(settings.CUSTOM_LOGO_URL)}") | ||||||||||||||
| logger.log("COMET", f"Custom Addon Name: {bool(settings.CUSTOM_ADDON_NAME)}") | ||||||||||||||
| logger.log("COMET", f"Custom Discord URL: {bool(settings.CUSTOM_DISCORD_URL)}") | ||||||||||||||
|
Comment on lines
+446
to
+448
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Logging always shows These settings have hardcoded defaults in Consider checking whether the value differs from the default, or simply log the actual value (truncated if needed) for better operator visibility: Suggested approach- logger.log("COMET", f"Custom Logo URL: {bool(settings.CUSTOM_LOGO_URL)}")
- logger.log("COMET", f"Custom Addon Name: {bool(settings.CUSTOM_ADDON_NAME)}")
- logger.log("COMET", f"Custom Discord URL: {bool(settings.CUSTOM_DISCORD_URL)}")
+ logger.log("COMET", f"Custom Logo URL: {settings.CUSTOM_LOGO_URL}")
+ logger.log("COMET", f"Custom Addon Name: {settings.CUSTOM_ADDON_NAME}")
+ logger.log("COMET", f"Custom Discord URL: {settings.CUSTOM_DISCORD_URL}")Alternatively, define the defaults as constants and check 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
| logger.log("COMET", f"Custom Header HTML: {bool(settings.CUSTOM_HEADER_HTML)}") | ||||||||||||||
|
|
||||||||||||||
| http_cache_info = ( | ||||||||||||||
|
|
||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.