This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
adding JCB card #2058
Open
mihaileu
wants to merge
59
commits into
fzaninotto:master
Choose a base branch
from
mihaileu:adding_JCB_credit_card
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
adding JCB card #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
============================================
+ Coverage 56.56% 56.79% +0.22%
Complexity 2068 2068
============================================
Files 306 306
Lines 4849 4849
============================================
+ Hits 2743 2754 +11
+ Misses 2106 2095 -11
Continue to review full report at Codecov.
|
@pimjansen @fzaninotto still alive ? |
…rm populator (fzaninotto#1995) Bug: fzaninotto#1862 Clear specific entities is deprecated and will not be supported in Doctrine 3.0. (doctrine/orm@9ccb883) Bug introduced: c49cd54 Related issue: https://stackoverflow.com/questions/18215975/doctrine-a-new-entity-was-found-through-the-relationship
Thanks for your contribution
* Fix IBAN generation for CR (Costa Rica)
Fix generating lastname for female gender. Changed from latin 'a' to cyrillic 'а'
Co-Authored-By: Chris Döhring <[email protected]>
Updates the Danish addresses
Fix: Remove conflict with ergebnis/faker
* Standin replacement for LoremImage to Placeholder.com * Updated constant and stricter sprintf types * Removed BC * Null to empty string if no elements are set Co-authored-by: Chris Döhring <[email protected]> Co-authored-by: Chris Döhring <[email protected]>
Added 1.10.1 changelog
Limit workflow builds to main branch and PRs
* Add: Swedish municipality * Fix: rename class from Company to Municipality * Fix: Class should not extend * CS fixes * Bugfix * Added a small test Co-authored-by: sebastiansson <[email protected]>
* Try adding BC check * Run on PR * Added config file * Update bc-check.yml * trigger CI * Trigger CI * Added BC break * More BC break * Trigger CI * Revert BC break * cs * minor
This will make sure we push the source code to the correct direction
Co-authored-by: Alexey Kopytko <[email protected]>
Co-authored-by: Alexey Kopytko <[email protected]>
Co-authored-by: Alexey Kopytko <[email protected]>
Co-authored-by: Andreas Möller <[email protected]>
Brush up CI, add Windows build
…TEMPLATE.md Add PULL_REQUEST_TEMPLATE.md
Adding PHPStan and Psalm
This reverts commit 1fcc343.
…ctrine orm populator (fzaninotto#1995)" This reverts commit 5337ce5.
…Faker into adding_JCB_credit_card
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding JCB card type