luci-app-ssr-plus: fix multiline nft comments - #2035
Open
Bianzinan wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serialize IP-list metadata onto one comment line when persisting nftables rules. This leaves nft set population unchanged.
Reproduction
A multiline UCI value such as
8.153.77.177\n123.56.167.14previously wrote the second IP as a bare nftables line. The metadata echoes preserved embedded newlines, producing invalid99-shadowsocksr.nftsyntax.Validation
sh -n luci-app-ssr-plus/root/usr/bin/ssr-rulesgit diff --check