Fix situation in which edge commands are not triggered.#1318
Conversation
Situation is as follows. Application window is maximised. One opens a menu in that application. Menu is closed. One moves the pointer to an edge. Edge command is not triggered. This commit fixes that. Rationale: when refocusing too early, the edge is not considered anymore and not command is triggered.
ThomasAdam
left a comment
There was a problem hiding this comment.
Hi @tzimisces
If you do this, you'll cause problems with other windows.
Is this more of a timing issue, can you confirm?
|
No, I don't think it's a timing issue, and it's deterministic. What I observe for GTK-applications:
The above sequence results in the pointer not leaving the application window. Then, for some reason, Fvwm's state suggests that something should be done about a window whose focus is stolen. For as far as I can see, the only consequence of this change is the fact that the right "window" is evaluated for the presence of an edge command, and that after that, things proceed like before. Thing is, the "ewp"-pointer changes after the refocus, so the pan frame is not considered anymore. What problems would this change yield for other windows? |
Situation is as follows. Application window is maximised. One opens a menu in that application. Menu is closed. One moves the pointer to an edge. Edge command is not triggered.
This commit fixes that. Rationale: when refocusing too early, the edge is not considered anymore and not command is triggered.