Fix moving windows from one desktop to another.#1317
Open
tzimisces wants to merge 1 commit into
Open
Conversation
It turns out that windows disappear when being moved from one desktop to another, when the current desktop is the desktop the window is to be moved to, and, yes, the original desktop is not the current one ;) I believe this fixes that problem.
ThomasAdam
requested changes
May 18, 2026
Comment on lines
-2249
to
+2253
| fw->Desk = m->virtual_scr.CurrentDesk; | ||
| if (fw->Desk != m->virtual_scr.CurrentDesk) | ||
| { | ||
| fw->UpdateDesk = m->virtual_scr.CurrentDesk; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
No -- I'm not sure this is correct; the current desk gets updated when fvwm_update_screen() is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that windows disappear when being moved from one desktop to another, when the current desktop is the desktop the window is to be moved to, and, yes, the original desktop is not the current one ;)
I believe this fixes that problem.