Fix switching monitors which are located at the same position.#1316
Merged
Conversation
When simultaneously disabling and enabling monitor which are placed at the same position, Fvwm will chicken out because it comes to believe that no monitor is active anymore. This is in a sense caused by the way scan_screens processes changes, however, can be fixed by changing monitor_compare. The latter only considers the position of a monitor, and if a monitor is en - or disabled. When inserting a monitor into the RB-tree, a previously unknown monitor will be considered the same as the one being disabled. By extending the criteria by which monitors are checked, monitors which actually differ are not considered being the same anymore, and a previously unknown one is properly added to the RB-tree. After insertion, the process in scan_screens will yield a correct configuration and Fvwm will happily continue. fixes fvwmorg#1281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When simultaneously disabling and enabling monitor which are placed at the same position, Fvwm will chicken out because it comes to believe that no monitor is active anymore.
This is in a sense caused by the way scan_screens processes changes, however, can be fixed by changing monitor_compare. The latter only considers the position of a monitor, and if a monitor is en - or disabled. When inserting a monitor into the RB-tree, a previously unknown monitor will be considered the same as the one being disabled.
By extending the criteria by which monitors are checked, monitors which actually differ are not considered being the same anymore, and a previously unknown one is properly added to the RB-tree. After insertion, the process in scan_screens will yield a correct configuration and Fvwm will happily continue.
fixes #1281