events: restrict Expose weeding scope to prevent cross-window coalescing#1310
Open
JRRandall wants to merge 1 commit into
Open
events: restrict Expose weeding scope to prevent cross-window coalescing#1310JRRandall wants to merge 1 commit into
JRRandall wants to merge 1 commit into
Conversation
Expose events could be coalesced across multiple windows within a single weeding pass, which may drop repaint obligations when one window's Expose activity invalidates another's. Return both match (rc & 1) and stop (rc & 2) for Expose events so each weeding pass operates on a smaller scope, preventing cross-window coalescing while preserving the existing pipeline.
Author
|
@ThomasAdam This patch is intentionally minimal and scoped to the observed regression: it restricts Expose coalescing to a single window per weeding pass without changing the overall event handling architecture or removing the existing pipeline behavior. The goal here is strictly to prevent cross-window interaction during Expose processing, which is where the repaint issue was consistently observed. I’m happy to iterate further if there’s a preferred long-term direction for more structured per-window coalescing, but from the testing so far this resolves the practical regression without introducing broader behavioral changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expose events are currently processed within a single weeding pass, which can coalesce events across multiple windows. In some cases, this can result in repaint obligations being dropped when Expose activity from one window affects another.
This change keeps the existing weeding pipeline intact, but returns both match (
rc & 1) and stop (rc & 2) for Expose events. This limits each weeding pass to a smaller scope so Expose events are not coalesced across unrelated windows.This preserves existing event handling behavior while preventing cross-window interaction during Expose coalescing.
Screenshots (if applicable)
N/A (behavioral fix; verified via
xev -idand icon repaint testing)Issue number(s)
Fixes #818