Skip to content

Fix casting unmuxed-HLS sources (Nebula) to FCast and Chromecast #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajcoll5 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix casting unmuxed-HLS sources (Nebula) to FCast and Chromecast #3477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
679703e
casting: fix HLS casting crash and Chromecast playback for unmuxed so…
ajcoll5 Aug 28, 2026
f6871d1
casting: omit "und" language tag from HLS audio for Chromecast
ajcoll5 Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 51 additions & 6 deletions app/src/main/java/com/futo/platformplayer/casting/StateCasting.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,23 @@ class StateCasting {
Logger.i(TAG, "Casting as raw DASH");

castDashRaw(contentResolver, video, videoSource as JSDashManifestRawSource?, audioSource as JSDashManifestRawAudioSource?, subtitleSource, resumePosition, speed, castId, onLoadingEstimate, onLoading);
} else if (videoSource is IHLSManifestSource) {
//Some plugins (e.g. Nebula) report unmuxed video+audio that are actually the same HLS manifest - treat as one HLS source
Logger.i(TAG, "Casting as proxied HLS (video+audio both from same HLS manifest)");
val proxyStreams = shouldProxyStreams(ad, videoSource, audioSource)
if (proxyStreams || deviceProto == CastProtocolType.CHROMECAST) {
castProxiedHls(video, videoSource.url, videoSource.codec, resumePosition, speed, (videoSource as? JSSource)?.getRequestModifier());
} else {
ad.loadVideo(if (video.isLive) "LIVE" else "BUFFERED", videoSource.container, videoSource.url, resumePosition, video.duration.toDouble(), speed, metadataFromVideo(video));
}
} else if (audioSource is IHLSManifestAudioSource) {
Logger.i(TAG, "Casting as proxied HLS (audio-only HLS manifest)");
val proxyStreams = shouldProxyStreams(ad, videoSource, audioSource)
if (proxyStreams || deviceProto == CastProtocolType.CHROMECAST) {
castProxiedHls(video, audioSource.url, audioSource.codec, resumePosition, speed, (audioSource as? JSSource)?.getRequestModifier());
} else {
ad.loadVideo(if (video.isLive) "LIVE" else "BUFFERED", audioSource.container, audioSource.url, resumePosition, video.duration.toDouble(), speed, metadataFromVideo(video));
}
} else {
Logger.i(TAG, "Casting as DASH indirect");
castDashIndirect(contentResolver, video, videoSource as IVideoUrlSource?, audioSource as IAudioUrlSource?, subtitleSource, resumePosition, speed);
Expand Down Expand Up @@ -935,7 +952,7 @@ class StateCasting {

val masterPlaylist: HLS.MasterPlaylist
try {
masterPlaylist = HLS.parseMasterPlaylist(masterPlaylistContent, sourceUrl)
masterPlaylist = HLS.parseMasterPlaylist(masterPlaylistContent, masterPlaylistResponse.url)
} catch (e: Throwable) {
if (masterPlaylistContent.lines().any { it.startsWith("#EXTINF:") }) {
//This is a variant playlist, not a master playlist
Expand All @@ -945,7 +962,7 @@ class StateCasting {
vpHeaders["Content-Type"] = "application/vnd.apple.mpegurl";

val variantPlaylist =
HLS.parseVariantPlaylist(masterPlaylistContent, sourceUrl)
HLS.parseVariantPlaylist(masterPlaylistContent, masterPlaylistResponse.url)
val proxiedVariantPlaylist =
proxyVariantPlaylist(url, id, variantPlaylist, video.isLive, requestModifier)
val proxiedVariantPlaylist_m3u8 = proxiedVariantPlaylist.buildM3U8()
Expand Down Expand Up @@ -989,7 +1006,7 @@ class StateCasting {
?: throw Exception("Variant playlist content is empty")

val variantPlaylist =
HLS.parseVariantPlaylist(vpContent, variantPlaylistRef.url)
HLS.parseVariantPlaylist(vpContent, response.url)
val proxiedVariantPlaylist =
proxyVariantPlaylist(url, playlistId, variantPlaylist, video.isLive, requestModifier)
val proxiedVariantPlaylist_m3u8 = proxiedVariantPlaylist.buildM3U8()
Expand Down Expand Up @@ -1029,7 +1046,7 @@ class StateCasting {
?: throw Exception("Variant playlist content is empty")

val variantPlaylist =
HLS.parseVariantPlaylist(vpContent, mediaRendition.uri)
HLS.parseVariantPlaylist(vpContent, response.url)
val proxiedVariantPlaylist = proxyVariantPlaylist(
url, playlistId, variantPlaylist, video.isLive, requestModifier
)
Expand All @@ -1043,7 +1060,8 @@ class StateCasting {
mediaRendition.type,
newPlaylistUrl,
mediaRendition.groupID,
mediaRendition.language,
//ChromeCast rejects the "und" language tag
mediaRendition.language?.takeIf { it != "und" },
mediaRendition.name,
mediaRendition.isDefault,
mediaRendition.isAutoSelect,
Expand Down Expand Up @@ -1085,6 +1103,12 @@ class StateCasting {
newSegments.addAll(variantPlaylist.segments)
}

val newMapUrl = if (proxySegments) {
variantPlaylist.mapUrl?.let { proxyInitSegment(url, playlistId, it, requestModifier) }
} else {
variantPlaylist.mapUrl
}

return HLS.VariantPlaylist(
variantPlaylist.version,
variantPlaylist.targetDuration,
Expand All @@ -1093,10 +1117,31 @@ class StateCasting {
variantPlaylist.programDateTime,
variantPlaylist.playlistType,
variantPlaylist.streamInfo,
newSegments
newSegments,
variantPlaylist.decryptionInfo,
newMapUrl,
variantPlaylist.mapBytesStart,
variantPlaylist.mapBytesLength,
variantPlaylist.unhandled
)
}

private fun proxyInitSegment(url: String, playlistId: UUID, mapUrl: String, requestModifier: IRequestModifier?): String {
val newSegmentPath = "/hls-playlist-${playlistId}-init"
val newSegmentUrl = url + newSegmentPath;

if (_castServer.getHandler("GET", newSegmentPath) == null) {
_castServer.addHandlerWithAllowAllOptions(
HttpProxyHandler("GET", newSegmentPath, mapUrl, true)
.withIRequestModifier(requestModifier)
.withInjectedHost()
.withHeader("Access-Control-Allow-Origin", "*"), true
).withTag("castProxiedHlsVariant")
}

return newSegmentUrl
}

private fun proxySegment(url: String, playlistId: UUID, segment: HLS.Segment, index: Long, requestModifier: IRequestModifier?): HLS.Segment {
if (segment is HLS.MediaSegment) {
val newSegmentPath = "/hls-playlist-${playlistId}-segment-${index}"
Expand Down