Use updateErrors so fields are touched and server errors visible#1
Open
tabby-or-not wants to merge 2 commits intofurious-luke:masterfrom
Open
Use updateErrors so fields are touched and server errors visible#1tabby-or-not wants to merge 2 commits intofurious-luke:masterfrom
tabby-or-not wants to merge 2 commits intofurious-luke:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 7 7
Lines 194 194
Branches 34 34
=======================================
Hits 186 186
Misses 8 8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors thrown during submit currently aren't visible as the fields are not "touched"
If we use
updateErrorsinstead ofsetErrors, these fields will be "touched" and the errors accessible through the proxy.