[pull] master from benjojo:master - #4
Open
pull[bot] wants to merge 32 commits into
Open
Conversation
Fix error checking, add Dockerfile
I generally run these bins as systemd services, but you want to go all galaxy brain yourselves, here is the convenient option
Send alerts in Discord's rich embed format
As we default to 127.0.0.1 in the code
Add listen.address as a CLI parameter and check WebHook
and if it does not match the discord regex it prints a warning but lets things go ahead, this is handy for debugging and canary subdomains of discord. H/T to Tom Bowditch who discovered the latter part
Because listen.address was hard coded in the Docker file, it would override any ENVVAR set in any other docker file, this made it hard to change the default listening port to anything else. By switching to `ENV LISTEN_ADDRESS=0.0.0.0:9094` people should be able to override the address that the docker file listens on much easier. This closes #12 This closes #11
Removed GOARCH parameter to be able to build arm images
This is to assist debugging #18 - But should be harmless to everyone else
idk it stopped working with: ---> Running in 74be85315501 1mgo: cannot find main module, but found .git/config in /go/src/mypackage/myapp to create a module there, run: go mod init Removing intermediate container 74be85315501 The command '/bin/sh -c go get -d -v' returned a non-zero code: 1 ---
Refactoring main.go
This fixes #23 Since if listening failes on http.ListenAndServe then it would simply hit the end of main() and thus exit with the status code of 0, systemd or other task orchestration systems may not restart on the count that the program did not technically signal it failed.
Closes #25
Account for discord webhook IDs with length 19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )