Skip to content

chore: keep release-please PRs out of Prettier and the benchmarks - #124

Merged
funkadelic merged 2 commits into
mainfrom
chore/prettier-ignore-release-manifest
Oct 4, 2026
Merged

funkadelic merged 2 commits into
mainfrom
chore/prettier-ignore-release-manifest

Conversation

@funkadelic

@funkadelic funkadelic commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

adds the release-please manifest to the Prettier ignore list and skips the benchmark job on release PRs


Summary by cubic

Keeps release-please PRs out of Prettier and the benchmark job.

  • Excludes .release-please-manifest.json from Prettier so its formatting no longer drifts on every release.
  • Skips the benchmark job on release-please PRs, since they only change the version and changelog.

Written for commit 06da1df. Summary will update on new commits.

Review in cubic

@funkadelic funkadelic self-assigned this Oct 4, 2026
@funkadelic
funkadelic marked this pull request as ready for review October 4, 2026 04:38

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@codspeed

codspeed Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 27 untouched benchmarks


Comparing chore/prettier-ignore-release-manifest (06da1df) with main (e9fe150)

Open in CodSpeed

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e9fe150) to head (06da1df).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines          796       796           
  Branches       149       149           
=========================================
  Hits           796       796           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Lighthouse, median of 3 mobile runs

Page Score FCP LCP TBT CLS Speed Index
Cities 100 1.1s 1.4s 10ms 0.000 1.1s
Films 94 1.4s 3.0s 0ms 0.000 1.4s

Full reports

@funkadelic
funkadelic merged commit 7d28d0e into main Oct 4, 2026
17 checks passed
@funkadelic
funkadelic deleted the chore/prettier-ignore-release-manifest branch October 4, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant