Skip to content

test: drop toolchain guards that pin README prose or repeat CI failures - #119

Merged
funkadelic merged 1 commit into
feat/publish-the-table-as-an-npm-packagefrom
test/trim-toolchain-guards
Oct 4, 2026
Merged

funkadelic merged 1 commit into
feat/publish-the-table-as-an-npm-packagefrom
test/trim-toolchain-guards

Conversation

@funkadelic

@funkadelic funkadelic commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

removes toolchain checks that pinned README wording or repeated failures CI already reports, and drops the version numbers from the README stack list


Summary by cubic

Removes toolchain guards that pinned README prose or repeated failures CI already reports, and drops the version numbers from the README stack list.

Refactors

  • Deletes five prose-pinning guards and their helper literals from src/toolchain.test.ts.
  • Removes guards for test runner selection, Lighthouse binary resolution, global fake clocks, and coverage provider choice, since CI already surfaces those failures.
  • Trims the dataset ceiling comments in films.ts and cities.ts that referenced a removed guard.
  • Updates the address invariant comment to match the narrowed guard scope.

Dependencies

  • Removes version numbers from the README Stack list for TypeScript, React, Vite, and Vitest.

Written for commit 512081e. Summary will update on new commits.

Review in cubic

@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4c523d4) to head (512081e).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                            Coverage Diff                             @@
##           feat/publish-the-table-as-an-npm-package      #119   +/-   ##
==========================================================================
  Coverage                                    100.00%   100.00%           
==========================================================================
  Files                                            49        49           
  Lines                                           796       796           
  Branches                                        149       149           
==========================================================================
  Hits                                            796       796           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Lighthouse, median of 3 mobile runs

Page Score FCP LCP TBT CLS Speed Index
Cities 100 1.1s 1.4s 0ms 0.000 1.1s
Films 94 1.1s 3.0s 0ms 0.000 1.1s

Full reports

@codspeed

codspeed Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 27 untouched benchmarks


Comparing test/trim-toolchain-guards (512081e) with feat/publish-the-table-as-an-npm-package (4c523d4)

Open in CodSpeed

@funkadelic
funkadelic marked this pull request as ready for review October 4, 2026 04:23
@funkadelic funkadelic self-assigned this Oct 4, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@funkadelic
funkadelic merged commit 0af4774 into feat/publish-the-table-as-an-npm-package Oct 4, 2026
14 checks passed
@funkadelic
funkadelic deleted the test/trim-toolchain-guards branch October 4, 2026 04:26
funkadelic added a commit that referenced this pull request Oct 4, 2026
* feat: build the table as an installable npm package

* feat: import the table through its package name, resolved to source

* ci: release through release-please and publish to npm with provenance

* docs: record publishing the table as an npm package

* test: pin the English default labels

* feat: ship English default labels with the table

* feat: route the demo through the package entry and type-check every public type

* feat: prefix every design token with yart

* feat: ship native light-dark() and the forced-colors remap with the table

* feat: typecheck the package under nodenext resolution

* ci: lint the packed tarball with publint and attw

* docs: record the light-dark() floor and the prefixed, layered tokens

* docs: document installing, styling and labeling the npm package

* ci: pack the tarball in a job without publish rights

* ci: require npm 11.5.1 to publish and time-box release-please

* ci: find the first release's changelog heading, which has no brackets

* ci: file dependency bumps under Dependencies and keep tooling changes out of releases

* docs: note that every package export is client code under server components

* fix: keep the forced-colors remap ahead of a host's token overrides

* docs: say which npm releases enforce the Node 24 floor

* test: catch a Sass import in the published declarations

* feat: expose package.json through the exports map

* fix: let a host share its own react-icons 5.x

* test: install the lowest React the peer range admits in the package smoke

* docs: fold the remap and react-icons decisions into their records

* ci: keep dev dependency bumps out of releases and hold the react-icons floor

* fix: run the benchmarks against source when the package entry pulls in styles

* fix: share the build floor, source condition and class names across the build configs

* test: match stylesheet imports in the published declarations by specifier

* docs: complete the README snippet imports and narrow two overstated claims

* docs: point the browser floor at vite.shared.ts

* fix: keep the forced-colors remap ahead of a themed root override

* chore: use US spelling in the stylelint color messages

* docs: tighten the package docs and comments

* docs: make the search example a complete component

* test: typecheck the README examples against the packed tarball

* test: drop toolchain guards that pin prose or duplicate loud failures (#119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant